nvmet-fc: put ref when assoc->del_work is already scheduled

igaw · Christoph Hellwig · commit 70289ae5cac4 · 2025-04-09T13:03:56.000+02:00
Do not leak the tgtport reference when the work is already scheduled.

Signed-off-by: Daniel Wagner &lt;wagi@kernel.org&gt;
Reviewed-by: Hannes Reinecke &lt;hare@suse.de&gt;
Signed-off-by: Christoph Hellwig &lt;hch@lst.de&gt;
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
@@ -1073,7 +1073,8 @@ static void
 nvmet_fc_schedule_delete_assoc(struct nvmet_fc_tgt_assoc *assoc)
 {
 	nvmet_fc_tgtport_get(assoc->tgtport);
-	queue_work(nvmet_wq, &assoc->del_work);
+	if (!queue_work(nvmet_wq, &assoc->del_work))
+		nvmet_fc_tgtport_put(assoc->tgtport);
 }
 
 static bool

Original file line number	Diff line number	Diff line change
`@@ -1073,7 +1073,8 @@ static void`
`1073`	`1073`	`nvmet_fc_schedule_delete_assoc(struct nvmet_fc_tgt_assoc *assoc)`
`1074`	`1074`	`{`
`1075`	`1075`	`nvmet_fc_tgtport_get(assoc->tgtport);`
`1076`		`- queue_work(nvmet_wq, &assoc->del_work);`
	`1076`	`+ if (!queue_work(nvmet_wq, &assoc->del_work))`
	`1077`	`+ nvmet_fc_tgtport_put(assoc->tgtport);`
`1077`	`1078`	`}`
`1078`	`1079`
`1079`	`1080`	`static bool`