Skip to content

Commit 7083e14

Browse files
aspeedtechKAGA-KOKO
authored andcommitted
dt-bindings: interrupt-controller: aspeed,ast2700: Correct #interrupt-cells and interrupts count
Update the AST2700 interrupt controller binding to match the actual hardware and the irq-aspeed-intc driver behavior. - Interrupts: First-level INTC banks request multiple interrupt lines to the root GIC, with a maximum of 10 per bank. Second-level INTC banks request only one interrupt line to their parent INTC-IC. Therefore, set the interrupts property to allow a minimum of 1 and a maximum of 10 entries. - #interrupt-cells: Set '#interrupt-cells' to <1> since the aspeed intc driver does not support specifying a trigger type; only the interrupt index is used. Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://patch.msgid.link/20251030060155.2342604-2-ryan_chen@aspeedtech.com
1 parent 47a4ebb commit 7083e14

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,14 @@ properties:
2525
interrupt-controller: true
2626

2727
'#interrupt-cells':
28-
const: 2
28+
const: 1
2929
description:
3030
The first cell is the IRQ number, the second cell is the trigger
3131
type as defined in interrupt.txt in this directory.
3232

3333
interrupts:
34-
maxItems: 6
34+
minItems: 1
35+
maxItems: 10
3536
description: |
3637
Depend to which INTC0 or INTC1 used.
3738
INTC0 and INTC1 are two kinds of interrupt controller with enable and raw
@@ -74,13 +75,17 @@ examples:
7475
interrupt-controller@12101b00 {
7576
compatible = "aspeed,ast2700-intc-ic";
7677
reg = <0 0x12101b00 0 0x10>;
77-
#interrupt-cells = <2>;
78+
#interrupt-cells = <1>;
7879
interrupt-controller;
7980
interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>,
8081
<GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>,
8182
<GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>,
8283
<GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>,
8384
<GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>,
84-
<GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>;
85+
<GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>,
86+
<GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>,
87+
<GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>,
88+
<GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>,
89+
<GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>;
8590
};
8691
};

0 commit comments

Comments
 (0)