Skip to content

Commit 70a6404

Browse files
pujarsbroonie
authored andcommitted
ASoC: rt5640: Fix sleep in atomic context
Following prints are observed while testing audio on Jetson AGX Orin which has onboard RT5640 audio codec: BUG: sleeping function called from invalid context at kernel/workqueue.c:3027 in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0 preempt_count: 10001, expected: 0 RCU nest depth: 0, expected: 0 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 0 at kernel/irq/handle.c:159 __handle_irq_event_percpu+0x1e0/0x270 ---[ end trace ad1c64905aac14a6 ]- The IRQ handler rt5640_irq() runs in interrupt context and can sleep during cancel_delayed_work_sync(). Fix this by running IRQ handler, rt5640_irq(), in thread context. Hence replace request_irq() calls with devm_request_threaded_irq(). Fixes: 051dade ("ASoC: rt5640: Fix the wrong state of JD1 and JD2") Cc: stable@vger.kernel.org Cc: Oder Chiou <oder_chiou@realtek.com> Signed-off-by: Sameer Pujar <spujar@nvidia.com> Link: https://lore.kernel.org/r/1688015537-31682-4-git-send-email-spujar@nvidia.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 6dfe70b commit 70a6404

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

sound/soc/codecs/rt5640.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2567,9 +2567,10 @@ static void rt5640_enable_jack_detect(struct snd_soc_component *component,
25672567
if (jack_data && jack_data->use_platform_clock)
25682568
rt5640->use_platform_clock = jack_data->use_platform_clock;
25692569

2570-
ret = request_irq(rt5640->irq, rt5640_irq,
2571-
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
2572-
"rt5640", rt5640);
2570+
ret = devm_request_threaded_irq(component->dev, rt5640->irq,
2571+
NULL, rt5640_irq,
2572+
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
2573+
"rt5640", rt5640);
25732574
if (ret) {
25742575
dev_warn(component->dev, "Failed to reguest IRQ %d: %d\n", rt5640->irq, ret);
25752576
rt5640_disable_jack_detect(component);
@@ -2622,8 +2623,9 @@ static void rt5640_enable_hda_jack_detect(
26222623

26232624
rt5640->jack = jack;
26242625

2625-
ret = request_irq(rt5640->irq, rt5640_irq,
2626-
IRQF_TRIGGER_RISING | IRQF_ONESHOT, "rt5640", rt5640);
2626+
ret = devm_request_threaded_irq(component->dev, rt5640->irq,
2627+
NULL, rt5640_irq, IRQF_TRIGGER_RISING | IRQF_ONESHOT,
2628+
"rt5640", rt5640);
26272629
if (ret) {
26282630
dev_warn(component->dev, "Failed to reguest IRQ %d: %d\n", rt5640->irq, ret);
26292631
rt5640->irq = -ENXIO;

0 commit comments

Comments
 (0)