Skip to content

Commit 70c2cf2

Browse files
lategoodbyeffainelli
authored andcommitted
firmware: raspberrypi: Improve timeout warning
Recent work on raspberry-power driver showed that even the stacktrace on firmware property timeout doesn't provide enough information. So add the first tag name to the warning to be in line with a status error. Signed-off-by: Stefan Wahren <wahrenst@gmx.net> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://lore.kernel.org/r/20240728114200.75559-2-wahrenst@gmx.net Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
1 parent 8400291 commit 70c2cf2

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/firmware/raspberrypi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ rpi_firmware_transaction(struct rpi_firmware *fw, u32 chan, u32 data)
6262
ret = 0;
6363
} else {
6464
ret = -ETIMEDOUT;
65-
WARN_ONCE(1, "Firmware transaction timeout");
6665
}
6766
} else {
6867
dev_err(fw->cl.dev, "mbox_send_message returned %d\n", ret);
@@ -125,6 +124,8 @@ int rpi_firmware_property_list(struct rpi_firmware *fw,
125124
dev_err(fw->cl.dev, "Request 0x%08x returned status 0x%08x\n",
126125
buf[2], buf[1]);
127126
ret = -EINVAL;
127+
} else if (ret == -ETIMEDOUT) {
128+
WARN_ONCE(1, "Firmware transaction 0x%08x timeout", buf[2]);
128129
}
129130

130131
dma_free_coherent(fw->chan->mbox->dev, PAGE_ALIGN(size), buf, bus_addr);

0 commit comments

Comments
 (0)