Skip to content

Commit 70e94d7

Browse files
committed
NFSD: Combine XDR error tracepoints
Clean up: The garbage_args and cant_encode tracepoints report the same information as each other, so combine them into a single tracepoint class to reduce code duplication and slightly reduce the size of trace.o. Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 5089f3d commit 70e94d7

1 file changed

Lines changed: 7 additions & 21 deletions

File tree

fs/nfsd/trace.h

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
rqstp->rq_xprt->xpt_remotelen); \
4848
} while (0);
4949

50-
TRACE_EVENT(nfsd_garbage_args_err,
50+
DECLARE_EVENT_CLASS(nfsd_xdr_err_class,
5151
TP_PROTO(
5252
const struct svc_rqst *rqstp
5353
),
@@ -69,27 +69,13 @@ TRACE_EVENT(nfsd_garbage_args_err,
6969
)
7070
);
7171

72-
TRACE_EVENT(nfsd_cant_encode_err,
73-
TP_PROTO(
74-
const struct svc_rqst *rqstp
75-
),
76-
TP_ARGS(rqstp),
77-
TP_STRUCT__entry(
78-
NFSD_TRACE_PROC_ARG_FIELDS
72+
#define DEFINE_NFSD_XDR_ERR_EVENT(name) \
73+
DEFINE_EVENT(nfsd_xdr_err_class, nfsd_##name##_err, \
74+
TP_PROTO(const struct svc_rqst *rqstp), \
75+
TP_ARGS(rqstp))
7976

80-
__field(u32, vers)
81-
__field(u32, proc)
82-
),
83-
TP_fast_assign(
84-
NFSD_TRACE_PROC_ARG_ASSIGNMENTS
85-
86-
__entry->vers = rqstp->rq_vers;
87-
__entry->proc = rqstp->rq_proc;
88-
),
89-
TP_printk("xid=0x%08x vers=%u proc=%u",
90-
__entry->xid, __entry->vers, __entry->proc
91-
)
92-
);
77+
DEFINE_NFSD_XDR_ERR_EVENT(garbage_args);
78+
DEFINE_NFSD_XDR_ERR_EVENT(cant_encode);
9379

9480
#define show_nfsd_may_flags(x) \
9581
__print_flags(x, "|", \

0 commit comments

Comments
 (0)