Skip to content

Commit 71b1e3b

Browse files
qzhuo2aegl
authored andcommitted
EDAC/skx: Fix overflows on the DRAM row address mapping arrays
The current DRAM row address mapping arrays skx_{open,close}_row[] only support ranks with sizes up to 16G. Decoding a rank address to a DRAM row address for a 32G rank by using either one of the above arrays by the skx_edac driver, will result in an overflow on the array. For a 32G rank, the most significant DRAM row address bit (the bit17) is mapped from the bit34 of the rank address. Add this new mapping item to both arrays to fix the overflow issue. Fixes: 4ec656b ("EDAC, skx_edac: Add EDAC driver for Skylake") Reported-by: Feng Xu <feng.f.xu@intel.com> Tested-by: Feng Xu <feng.f.xu@intel.com> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com> Signed-off-by: Tony Luck <tony.luck@intel.com> Link: https://lore.kernel.org/all/20230211011728.71764-1-qiuxu.zhuo@intel.com
1 parent eeac8ed commit 71b1e3b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/edac/skx_base.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -510,15 +510,15 @@ static bool skx_rir_decode(struct decoded_addr *res)
510510
}
511511

512512
static u8 skx_close_row[] = {
513-
15, 16, 17, 18, 20, 21, 22, 28, 10, 11, 12, 13, 29, 30, 31, 32, 33
513+
15, 16, 17, 18, 20, 21, 22, 28, 10, 11, 12, 13, 29, 30, 31, 32, 33, 34
514514
};
515515

516516
static u8 skx_close_column[] = {
517517
3, 4, 5, 14, 19, 23, 24, 25, 26, 27
518518
};
519519

520520
static u8 skx_open_row[] = {
521-
14, 15, 16, 20, 28, 21, 22, 23, 24, 25, 26, 27, 29, 30, 31, 32, 33
521+
14, 15, 16, 20, 28, 21, 22, 23, 24, 25, 26, 27, 29, 30, 31, 32, 33, 34
522522
};
523523

524524
static u8 skx_open_column[] = {

0 commit comments

Comments
 (0)