Skip to content

Commit 72a597a

Browse files
Uwe Kleine-Königdianders
authored andcommitted
drm/panel-edp: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. panel_edp_remove() always returned zero, so convert it to return void without any loss and then just drop the return from panel_edp_platform_remove(). Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230530074216.2195962-1-u.kleine-koenig@pengutronix.de
1 parent 332af82 commit 72a597a

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

drivers/gpu/drm/panel/panel-edp.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -903,7 +903,7 @@ static int panel_edp_probe(struct device *dev, const struct panel_desc *desc,
903903
return err;
904904
}
905905

906-
static int panel_edp_remove(struct device *dev)
906+
static void panel_edp_remove(struct device *dev)
907907
{
908908
struct panel_edp *panel = dev_get_drvdata(dev);
909909

@@ -918,8 +918,6 @@ static int panel_edp_remove(struct device *dev)
918918

919919
kfree(panel->edid);
920920
panel->edid = NULL;
921-
922-
return 0;
923921
}
924922

925923
static void panel_edp_shutdown(struct device *dev)
@@ -1934,9 +1932,9 @@ static int panel_edp_platform_probe(struct platform_device *pdev)
19341932
return panel_edp_probe(&pdev->dev, id->data, NULL);
19351933
}
19361934

1937-
static int panel_edp_platform_remove(struct platform_device *pdev)
1935+
static void panel_edp_platform_remove(struct platform_device *pdev)
19381936
{
1939-
return panel_edp_remove(&pdev->dev);
1937+
panel_edp_remove(&pdev->dev);
19401938
}
19411939

19421940
static void panel_edp_platform_shutdown(struct platform_device *pdev)
@@ -1957,7 +1955,7 @@ static struct platform_driver panel_edp_platform_driver = {
19571955
.pm = &panel_edp_pm_ops,
19581956
},
19591957
.probe = panel_edp_platform_probe,
1960-
.remove = panel_edp_platform_remove,
1958+
.remove_new = panel_edp_platform_remove,
19611959
.shutdown = panel_edp_platform_shutdown,
19621960
};
19631961

0 commit comments

Comments
 (0)