nvme: fix parameter check in nvme_fault_inject_init()

Minjie Du · keithbusch · commit 733ba346d941 · 2023-07-12T08:48:33.000-07:00
Make IS_ERR() judge the debugfs_create_dir() function return.

Signed-off-by: Minjie Du &lt;duminjie@vivo.com&gt;
Reviewed-by: Christoph Hellwig &lt;hch@lst.de&gt;
Signed-off-by: Keith Busch &lt;kbusch@kernel.org&gt;
diff --git a/drivers/nvme/host/fault_inject.c b/drivers/nvme/host/fault_inject.c
@@ -27,7 +27,7 @@ void nvme_fault_inject_init(struct nvme_fault_inject *fault_inj,
 
 	/* create debugfs directory and attribute */
 	parent = debugfs_create_dir(dev_name, NULL);
-	if (!parent) {
+	if (IS_ERR(parent)) {
 		pr_warn("%s: failed to create debugfs directory\n", dev_name);
 		return;
 	}

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ void nvme_fault_inject_init(struct nvme_fault_inject *fault_inj,`
`27`	`27`
`28`	`28`	`/* create debugfs directory and attribute */`
`29`	`29`	`parent = debugfs_create_dir(dev_name, NULL);`
`30`		`- if (!parent) {`
	`30`	`+ if (IS_ERR(parent)) {`
`31`	`31`	`pr_warn("%s: failed to create debugfs directory\n", dev_name);`
`32`	`32`	`return;`
`33`	`33`	`}`