Skip to content

Commit 7406538

Browse files
committed
drm/i915/guc: Remove bogus null check
This null check is bogus because we are already using 'ce' stuff in many places before this function is called. Having this here is useless and confuses static analyzer tools that can see: struct intel_engine_cs *engine = ce->engine; before this check, in the same function. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202403101225.7AheJhZJ-lkp@intel.com/ Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com> Cc: John Harrison <John.C.Harrison@Intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240328213107.90632-1-rodrigo.vivi@intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 2bebae0 commit 7406538

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2677,7 +2677,7 @@ static int guc_context_policy_init_v70(struct intel_context *ce, bool loop)
26772677
execution_quantum = engine->props.timeslice_duration_ms * 1000;
26782678
preemption_timeout = engine->props.preempt_timeout_ms * 1000;
26792679

2680-
if (ce && (ce->flags & BIT(CONTEXT_LOW_LATENCY)))
2680+
if (ce->flags & BIT(CONTEXT_LOW_LATENCY))
26812681
slpc_ctx_freq_req |= SLPC_CTX_FREQ_REQ_IS_COMPUTE;
26822682

26832683
__guc_context_policy_start_klv(&policy, ce->guc_id.id);

0 commit comments

Comments
 (0)