fs/9p: Remove unnecessary superblock flags

ericvh · ericvh · commit 740b8bf87322 · 2023-03-27T02:33:47.000Z
These flags just add unnecessary extra operations.
When 9p is run without cache, it inherently implements
these options so we don't need them in the superblock
(which ends up sending extraneous fsyncs, etc.).  User
can still request these options on mount, but we don't
need to set them as default.

Signed-off-by: Eric Van Hensbergen &lt;ericvh@kernel.org&gt;
diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c
@@ -84,9 +84,7 @@ v9fs_fill_super(struct super_block *sb, struct v9fs_session_info *v9ses,
 		sb->s_bdi->io_pages = v9ses->maxdata >> PAGE_SHIFT;
 	}
 
-	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC;
-	if (!v9ses->cache)
-		sb->s_flags |= SB_SYNCHRONOUS;
+	sb->s_flags |= SB_ACTIVE;
 
 #ifdef CONFIG_9P_FS_POSIX_ACL
 	if ((v9ses->flags & V9FS_ACL_MASK) == V9FS_POSIX_ACL)

Original file line number	Diff line number	Diff line change
`@@ -84,9 +84,7 @@ v9fs_fill_super(struct super_block sb, struct v9fs_session_info v9ses,`
`84`	`84`	`sb->s_bdi->io_pages = v9ses->maxdata >> PAGE_SHIFT;`
`85`	`85`	`}`
`86`	`86`
`87`		`- sb->s_flags \|= SB_ACTIVE \| SB_DIRSYNC;`
`88`		`- if (!v9ses->cache)`
`89`		`- sb->s_flags \|= SB_SYNCHRONOUS;`
	`87`	`+ sb->s_flags \|= SB_ACTIVE;`
`90`	`88`
`91`	`89`	`#ifdef CONFIG_9P_FS_POSIX_ACL`
`92`	`90`	`if ((v9ses->flags & V9FS_ACL_MASK) == V9FS_POSIX_ACL)`