Skip to content

Commit 74bed42

Browse files
author
Tzung-Bi Shih
committed
platform/chrome: cros_ec_proto: add Kunit tests for cmd_xfer_status
cros_ec_cmd_xfer_status() calls cros_ec_cmd_xfer() and cros_ec_map_error(). Given that there are already test cases for cros_ec_cmd_xfer(), only add basic Kunit tests for cros_ec_cmd_xfer_status(). Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> Link: https://lore.kernel.org/r/20220622041040.202737-2-tzungbi@kernel.org
1 parent 3e1c715 commit 74bed42

1 file changed

Lines changed: 42 additions & 0 deletions

File tree

drivers/platform/chrome/cros_ec_proto_test.c

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1964,6 +1964,46 @@ static void cros_ec_proto_test_cmd_xfer_in_progress_return0(struct kunit *test)
19641964
KUNIT_EXPECT_EQ(test, cros_kunit_ec_pkt_xfer_mock_called, 2);
19651965
}
19661966

1967+
static void cros_ec_proto_test_cmd_xfer_status_normal(struct kunit *test)
1968+
{
1969+
struct cros_ec_proto_test_priv *priv = test->priv;
1970+
struct cros_ec_device *ec_dev = &priv->ec_dev;
1971+
struct ec_xfer_mock *mock;
1972+
int ret;
1973+
struct cros_ec_command msg;
1974+
1975+
memset(&msg, 0, sizeof(msg));
1976+
1977+
/* For cros_ec_cmd_xfer(). */
1978+
{
1979+
mock = cros_kunit_ec_xfer_mock_add(test, 0);
1980+
KUNIT_ASSERT_PTR_NE(test, mock, NULL);
1981+
}
1982+
1983+
ret = cros_ec_cmd_xfer_status(ec_dev, &msg);
1984+
KUNIT_EXPECT_EQ(test, ret, 0);
1985+
}
1986+
1987+
static void cros_ec_proto_test_cmd_xfer_status_xfer_error(struct kunit *test)
1988+
{
1989+
struct cros_ec_proto_test_priv *priv = test->priv;
1990+
struct cros_ec_device *ec_dev = &priv->ec_dev;
1991+
struct ec_xfer_mock *mock;
1992+
int ret;
1993+
struct cros_ec_command msg;
1994+
1995+
memset(&msg, 0, sizeof(msg));
1996+
1997+
/* For cros_ec_cmd_xfer(). */
1998+
{
1999+
mock = cros_kunit_ec_xfer_mock_addx(test, -EPROTO, EC_RES_SUCCESS, 0);
2000+
KUNIT_ASSERT_PTR_NE(test, mock, NULL);
2001+
}
2002+
2003+
ret = cros_ec_cmd_xfer_status(ec_dev, &msg);
2004+
KUNIT_EXPECT_EQ(test, ret, -EPROTO);
2005+
}
2006+
19672007
static void cros_ec_proto_test_release(struct device *dev)
19682008
{
19692009
}
@@ -2044,6 +2084,8 @@ static struct kunit_case cros_ec_proto_test_cases[] = {
20442084
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_xfer_error),
20452085
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_return_error),
20462086
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_return0),
2087+
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_status_normal),
2088+
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_status_xfer_error),
20472089
{}
20482090
};
20492091

0 commit comments

Comments
 (0)