Skip to content

Commit 74ec2f3

Browse files
author
Kent Overstreet
committed
bcachefs: fix restart handling in bch2_rename2()
This should be impossible to hit in practice; the first lookup within a transaction won't return a restart due to lock ordering, but we're adding fault injection for transaction restarts and shaking out bugs. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
1 parent 5e3b723 commit 74ec2f3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/bcachefs/fs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -871,7 +871,7 @@ static int bch2_rename2(struct mnt_idmap *idmap,
871871
ret = bch2_subvol_is_ro_trans(trans, src_dir->ei_inum.subvol) ?:
872872
bch2_subvol_is_ro_trans(trans, dst_dir->ei_inum.subvol);
873873
if (ret)
874-
goto err;
874+
goto err_tx_restart;
875875

876876
if (inode_attr_changing(dst_dir, src_inode, Inode_opt_project)) {
877877
ret = bch2_fs_quota_transfer(c, src_inode,

0 commit comments

Comments
 (0)