perf/x86/amd/uncore: Fix uninitialized return value in amd_uncore_init()

Dan Carpenter · ingomolnar · commit 7543365739a4 · 2023-10-13T09:32:50.000+02:00
Some of the error paths in this function return don't initialize the error code. Return -ENODEV by default. Fixes: d6389d3 ("perf/x86/amd/uncore: Refactor uncore management") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/cec62eba-c4b8-4cb7-9671-58894dd4b974@moroto.mountain
diff --git a/arch/x86/events/amd/uncore.c b/arch/x86/events/amd/uncore.c
@@ -1009,7 +1009,8 @@ static struct amd_uncore uncores[UNCORE_TYPE_MAX] = {
 static int __init amd_uncore_init(void)
 {
 	struct amd_uncore *uncore;
-	int ret, i;
+	int ret = -ENODEV;
+	int i;
 
 	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD &&
 	    boot_cpu_data.x86_vendor != X86_VENDOR_HYGON)

Original file line number	Diff line number	Diff line change
`@@ -1009,7 +1009,8 @@ static struct amd_uncore uncores[UNCORE_TYPE_MAX] = {`
`1009`	`1009`	`static int __init amd_uncore_init(void)`
`1010`	`1010`	`{`
`1011`	`1011`	`struct amd_uncore *uncore;`
`1012`		`- int ret, i;`
	`1012`	`+ int ret = -ENODEV;`
	`1013`	`+ int i;`
`1013`	`1014`
`1014`	`1015`	`if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD &&`
`1015`	`1016`	`boot_cpu_data.x86_vendor != X86_VENDOR_HYGON)`