Skip to content

Commit 75a978b

Browse files
costowellij-intel
authored andcommitted
intel-hid: fix volume buttons on Thinkpad X12 Detachable Tablet Gen 1
Volume buttons on Lenovo Thinkpad X12 Detachable Tablet Gen 1 did not send any input events when pressed. When loading intel-hid with the 5 Button Array explicitly enabled, the buttons functioned normally. Adds the X12 Detachable Tablet Gen 1 to the `button_array_table`. However, the driver is unable to call INTEL_HID_DSM_BTNE_FN and prints the warning "failed to set button capability" when attempting to enable or disable the 5 Button Array. The warning should be harmless and adding more special handling to avoid it is not worth it. Co-developed-by: Mary Strodl <mstrodl@csh.rit.edu> Signed-off-by: Mary Strodl <mstrodl@csh.rit.edu> Signed-off-by: Cole Stowell <cole@stowell.pro> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20241107205908.69279-1-cole@stowell.pro Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent 0d5e2d9 commit 75a978b

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

  • drivers/platform/x86/intel

drivers/platform/x86/intel/hid.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,13 @@ static const struct dmi_system_id button_array_table[] = {
118118
DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
119119
},
120120
},
121+
{
122+
.ident = "Lenovo ThinkPad X1 Tablet Gen 1",
123+
.matches = {
124+
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
125+
DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X12 Detachable Gen 1"),
126+
},
127+
},
121128
{
122129
.ident = "Lenovo ThinkPad X1 Tablet Gen 2",
123130
.matches = {

0 commit comments

Comments
 (0)