Skip to content

Commit 75b6979

Browse files
Matthew Wilcox (Oracle)dhowells
authored andcommitted
afs: Use wait_on_page_writeback_killable
Open-coding this function meant it missed out on the recent bugfix for waiters being woken by a delayed wake event from a previous instantiation of the page[1]. [DH: Changed the patch to use vmf->page rather than variable page which doesn't exist yet upstream] Fixes: 1cf7a15 ("afs: Implement shared-writeable mmap") Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: David Howells <dhowells@redhat.com> Tested-by: kafs-testing@auristor.com cc: linux-afs@lists.infradead.org cc: linux-mm@kvack.org Link: https://lore.kernel.org/r/20210320054104.1300774-4-willy@infradead.org Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c2407cf7d22d0c0d94cf20342b3b8f06f1d904e7 [1]
1 parent e5dbd33 commit 75b6979

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

fs/afs/write.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -851,8 +851,7 @@ vm_fault_t afs_page_mkwrite(struct vm_fault *vmf)
851851
fscache_wait_on_page_write(vnode->cache, vmf->page);
852852
#endif
853853

854-
if (PageWriteback(vmf->page) &&
855-
wait_on_page_bit_killable(vmf->page, PG_writeback) < 0)
854+
if (wait_on_page_writeback_killable(vmf->page))
856855
return VM_FAULT_RETRY;
857856

858857
if (lock_page_killable(vmf->page) < 0)

0 commit comments

Comments
 (0)