Skip to content

Commit 75e80b6

Browse files
author
Bartosz Golaszewski
committed
gpio: max3191x: remove unused callbacks
This driver is input-only and as such doesn't need to define empty set() and direction_output() callbacks. Remove them. Link: https://lore.kernel.org/r/20250506-gpiochip-set-rv-gpio-part3-v1-6-0fbdea5a9667@linaro.org Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
1 parent 2e6b7f5 commit 75e80b6

1 file changed

Lines changed: 0 additions & 16 deletions

File tree

drivers/gpio/gpio-max3191x.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -103,19 +103,6 @@ static int max3191x_direction_input(struct gpio_chip *gpio, unsigned int offset)
103103
return 0;
104104
}
105105

106-
static int max3191x_direction_output(struct gpio_chip *gpio,
107-
unsigned int offset, int value)
108-
{
109-
return -EINVAL;
110-
}
111-
112-
static void max3191x_set(struct gpio_chip *gpio, unsigned int offset, int value)
113-
{ }
114-
115-
static void max3191x_set_multiple(struct gpio_chip *gpio, unsigned long *mask,
116-
unsigned long *bits)
117-
{ }
118-
119106
static unsigned int max3191x_wordlen(struct max3191x_chip *max3191x)
120107
{
121108
return max3191x->mode == STATUS_BYTE_ENABLED ? 2 : 1;
@@ -421,9 +408,6 @@ static int max3191x_probe(struct spi_device *spi)
421408

422409
max3191x->gpio.get_direction = max3191x_get_direction;
423410
max3191x->gpio.direction_input = max3191x_direction_input;
424-
max3191x->gpio.direction_output = max3191x_direction_output;
425-
max3191x->gpio.set = max3191x_set;
426-
max3191x->gpio.set_multiple = max3191x_set_multiple;
427411
max3191x->gpio.get = max3191x_get;
428412
max3191x->gpio.get_multiple = max3191x_get_multiple;
429413
max3191x->gpio.set_config = max3191x_set_config;

0 commit comments

Comments
 (0)