f2fs: avoid duplicate call of mark_inode_dirty

Jaegeuk Kim · Jaegeuk Kim · commit 766c663933be · 2021-12-10T15:48:32.000-08:00
Let's check the condition first before set|clear bit.

Reviewed-by: Chao Yu &lt;chao@kernel.org&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
@@ -3115,12 +3115,16 @@ static inline int is_file(struct inode *inode, int type)
 
 static inline void set_file(struct inode *inode, int type)
 {
+	if (is_file(inode, type))
+		return;
 	F2FS_I(inode)->i_advise |= type;
 	f2fs_mark_inode_dirty_sync(inode, true);
 }
 
 static inline void clear_file(struct inode *inode, int type)
 {
+	if (!is_file(inode, type))
+		return;
 	F2FS_I(inode)->i_advise &= ~type;
 	f2fs_mark_inode_dirty_sync(inode, true);
 }

Original file line number	Diff line number	Diff line change
`@@ -3115,12 +3115,16 @@ static inline int is_file(struct inode *inode, int type)`
`3115`	`3115`
`3116`	`3116`	`static inline void set_file(struct inode *inode, int type)`
`3117`	`3117`	`{`
	`3118`	`+ if (is_file(inode, type))`
	`3119`	`+ return;`
`3118`	`3120`	`F2FS_I(inode)->i_advise \|= type;`
`3119`	`3121`	`f2fs_mark_inode_dirty_sync(inode, true);`
`3120`	`3122`	`}`
`3121`	`3123`
`3122`	`3124`	`static inline void clear_file(struct inode *inode, int type)`
`3123`	`3125`	`{`
	`3126`	`+ if (!is_file(inode, type))`
	`3127`	`+ return;`
`3124`	`3128`	`F2FS_I(inode)->i_advise &= ~type;`
`3125`	`3129`	`f2fs_mark_inode_dirty_sync(inode, true);`
`3126`	`3130`	`}`