Skip to content

Commit 76acb5e

Browse files
Andrzej Hajdagregkh
authored andcommitted
drm/bridge: lvds-codec: simplify error handling
Using dev_err_probe code has following advantages: - shorter code, - recorded defer probe reason for debugging, - uniform error code logging. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Link: https://lore.kernel.org/r/20200713144324.23654-5-a.hajda@samsung.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a60294d commit 76acb5e

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

drivers/gpu/drm/bridge/lvds-codec.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,9 @@ static int lvds_codec_probe(struct platform_device *pdev)
7171
lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev);
7272
lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown",
7373
GPIOD_OUT_HIGH);
74-
if (IS_ERR(lvds_codec->powerdown_gpio)) {
75-
int err = PTR_ERR(lvds_codec->powerdown_gpio);
76-
77-
if (err != -EPROBE_DEFER)
78-
dev_err(dev, "powerdown GPIO failure: %d\n", err);
79-
return err;
80-
}
74+
if (IS_ERR(lvds_codec->powerdown_gpio))
75+
return dev_err_probe(dev, PTR_ERR(lvds_codec->powerdown_gpio),
76+
"powerdown GPIO failure\n");
8177

8278
/* Locate the panel DT node. */
8379
panel_node = of_graph_get_remote_node(dev->of_node, 1, 0);

0 commit comments

Comments
 (0)