crypto: iaa - Fix incorrect return value in save_iaa_wq()

GoodLuck612 · herbertx · commit 76ce17f6f7f7 · 2025-11-14T18:15:49.000+08:00
The save_iaa_wq() function unconditionally returns 0, even when an error is encountered. This prevents the error code from being propagated to the caller. Fix this by returning the 'ret' variable, which holds the actual status of the operations within the function. Fixes: ea7a5cb ("crypto: iaa - Add Intel IAA Compression Accelerator crypto driver core") Signed-off-by: Zilin Guan <zilin@seu.edu.cn> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c
@@ -805,7 +805,7 @@ static int save_iaa_wq(struct idxd_wq *wq)
 	if (!cpus_per_iaa)
 		cpus_per_iaa = 1;
 out:
-	return 0;
+	return ret;
 }
 
 static void remove_iaa_wq(struct idxd_wq *wq)

Original file line number	Diff line number	Diff line change
`@@ -805,7 +805,7 @@ static int save_iaa_wq(struct idxd_wq *wq)`
`805`	`805`	`if (!cpus_per_iaa)`
`806`	`806`	`cpus_per_iaa = 1;`
`807`	`807`	`out:`
`808`		`- return 0;`
	`808`	`+ return ret;`
`809`	`809`	`}`
`810`	`810`
`811`	`811`	`static void remove_iaa_wq(struct idxd_wq *wq)`