ata: libata-sff: Fix compilation warning in ata_sff_lost_interrupt()

Damien Le Moal · Damien Le Moal · commit 76ed2f61ae3e · 2022-04-04T09:49:42.000+09:00
When returning false, ata_sff_altstatus() does not return any status value, resulting in a compilation warning in ata_sff_lost_interrupt() ("uninitialized symbol 'status'"). Fix this by initializing the local variable "status" to 0. Fixes: 03c0e84 ("ata: libata-sff: refactor ata_sff_altstatus()") Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
@@ -1634,7 +1634,7 @@ EXPORT_SYMBOL_GPL(ata_sff_interrupt);
 
 void ata_sff_lost_interrupt(struct ata_port *ap)
 {
-	u8 status;
+	u8 status = 0;
 	struct ata_queued_cmd *qc;
 
 	/* Only one outstanding command per SFF channel */

Original file line number	Diff line number	Diff line change
`@@ -1634,7 +1634,7 @@ EXPORT_SYMBOL_GPL(ata_sff_interrupt);`
`1634`	`1634`
`1635`	`1635`	`void ata_sff_lost_interrupt(struct ata_port *ap)`
`1636`	`1636`	`{`
`1637`		`- u8 status;`
	`1637`	`+ u8 status = 0;`
`1638`	`1638`	`struct ata_queued_cmd *qc;`
`1639`	`1639`
`1640`	`1640`	`/* Only one outstanding command per SFF channel */`