Skip to content

Commit 771725e

Browse files
daschbacbroonie
authored andcommitted
ASoC: tlv320adcx140: fix 'ti,gpio-config' DT property init
When the 'ti,gpio-config' property is not defined, the device_property_count_u32() will return an error, rather than zero. The current check, only handles a return value of zero, which assumes that the property is defined and has nothing defined. This change extends the check to also check for an error case (most likely to be hit by the case that the 'ti,gpio-config' is not defined). In case that the 'ti,gpio-config' and the returned 'gpio_count' is not correct, there is a 'if (gpio_count != ADCX140_NUM_GPIO_CFGS)' check, a few lines lower that will return -EINVAL. This means that someone tried to define 'ti,gpio-config', but with the wrong number of GPIOs. Fixes: d521432 ("ASoC: tlv320adcx140: Add support for configuring GPIO pin") Signed-off-by: Steffen Aschbacher <steffen.aschbacher@stihl.de> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro> Link: https://lore.kernel.org/r/20230213073805.14640-1-alex@shruggie.ro Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 4680716 commit 771725e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/soc/codecs/tlv320adcx140.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -925,7 +925,7 @@ static int adcx140_configure_gpio(struct adcx140_priv *adcx140)
925925

926926
gpio_count = device_property_count_u32(adcx140->dev,
927927
"ti,gpio-config");
928-
if (gpio_count == 0)
928+
if (gpio_count <= 0)
929929
return 0;
930930

931931
if (gpio_count != ADCX140_NUM_GPIO_CFGS)

0 commit comments

Comments
 (0)