Skip to content

Commit 7770683

Browse files
krzkandersson
authored andcommitted
soc: qcom: mention intentionally broken module autoloading
Qualcomm PMIC ChargerPD ULOG and RPM Master Statistics drivers are solely for debugging purposes and should not be autoloaded as modules. Add comments to annotate missing MODULE_DEVICE_TABLE. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20240410184522.271889-1-krzk@kernel.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent e478c5f commit 7770683

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

drivers/soc/qcom/pmic_pdcharger_ulog.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,10 @@ static const struct rpmsg_device_id pmic_pdcharger_ulog_rpmsg_id_match[] = {
150150
{ "PMIC_LOGS_ADSP_APPS" },
151151
{}
152152
};
153+
/*
154+
* No MODULE_DEVICE_TABLE intentionally: that's a debugging module, to be
155+
* loaded manually only.
156+
*/
153157

154158
static struct rpmsg_driver pmic_pdcharger_ulog_rpmsg_driver = {
155159
.probe = pmic_pdcharger_ulog_rpmsg_probe,

drivers/soc/qcom/rpm_master_stats.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,10 @@ static const struct of_device_id rpm_master_table[] = {
148148
{ .compatible = "qcom,rpm-master-stats" },
149149
{ },
150150
};
151+
/*
152+
* No MODULE_DEVICE_TABLE intentionally: that's a debugging module, to be
153+
* loaded manually only.
154+
*/
151155

152156
static struct platform_driver master_stats_driver = {
153157
.probe = master_stats_probe,

0 commit comments

Comments
 (0)