Skip to content

Commit 777967e

Browse files
Coly Liaxboe
authored andcommitted
bcache: check return value from btree_node_alloc_replacement()
In btree_gc_rewrite_node(), pointer 'n' is not checked after it returns from btree_gc_rewrite_node(). There is potential possibility that 'n' is a non NULL ERR_PTR(), referencing such error code is not permitted in following code. Therefore a return value checking is necessary after 'n' is back from btree_node_alloc_replacement(). Signed-off-by: Coly Li <colyli@suse.de> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20231120052503.6122-3-colyli@suse.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent baf8fb7 commit 777967e

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/md/bcache/btree.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1532,6 +1532,8 @@ static int btree_gc_rewrite_node(struct btree *b, struct btree_op *op,
15321532
return 0;
15331533

15341534
n = btree_node_alloc_replacement(replace, NULL);
1535+
if (IS_ERR(n))
1536+
return 0;
15351537

15361538
/* recheck reserve after allocating replacement node */
15371539
if (btree_check_reserve(b, NULL)) {

0 commit comments

Comments
 (0)