Skip to content

Commit 778031e

Browse files
MrChromeboxtiwai
authored andcommitted
ALSA: hda/ca0132: Set HP/Speaker auto-detect default from headphone pin verb
HP/Speaker auto-detect (VNID_HP_ASEL) has been off by default for every CA0132 device since the driver was added in 2012. vnode_lswitch is always initialized to 0 in ca0132_init_chip(), and no quirk or other code path enables it. As a result, headphone jack detection works only after the user manually turns on "HP/Speaker Auto Detect" in alsamixer, which is not obvious on laptops with combo jacks (e.g. Google Link, Alienware). Change the default to follow the headphone pin config: if the pin verb has presence detect enabled (no AC_DEFCFG_MISC_NO_PRESENCE) and the codec supports it (AC_PINCAP_PRES_DETECT), enable HP_ASEL by default. This lets firmware (coreboot, UEFI, etc.) express whether the headphone jack supports insertion detection. Devices with combo jacks can default to auto-detect; devices with fixed/no jack leave it off. Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Link: https://patch.msgid.link/20260226163055.825167-1-matt.devillier@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 71c1978 commit 778031e

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

sound/hda/codecs/ca0132.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9816,6 +9816,15 @@ static void ca0132_config(struct hda_codec *codec)
98169816
spec->dig_in = 0x09;
98179817
break;
98189818
}
9819+
9820+
/* Default HP/Speaker auto-detect from headphone pin verb: enable if the
9821+
* pin config indicates presence detect (not AC_DEFCFG_MISC_NO_PRESENCE).
9822+
*/
9823+
if (spec->unsol_tag_hp &&
9824+
(snd_hda_query_pin_caps(codec, spec->unsol_tag_hp) & AC_PINCAP_PRES_DETECT) &&
9825+
!(get_defcfg_misc(snd_hda_codec_get_pincfg(codec, spec->unsol_tag_hp)) &
9826+
AC_DEFCFG_MISC_NO_PRESENCE))
9827+
spec->vnode_lswitch[VNID_HP_ASEL - VNODE_START_NID] = 1;
98199828
}
98209829

98219830
static int ca0132_prepare_verbs(struct hda_codec *codec)

0 commit comments

Comments
 (0)