Skip to content

Commit 778dc8b

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: axi-clkgen: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-7-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 04d1918 commit 778dc8b

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/clk/clk-axi-clkgen.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -557,11 +557,9 @@ static int axi_clkgen_probe(struct platform_device *pdev)
557557
&axi_clkgen->clk_hw);
558558
}
559559

560-
static int axi_clkgen_remove(struct platform_device *pdev)
560+
static void axi_clkgen_remove(struct platform_device *pdev)
561561
{
562562
of_clk_del_provider(pdev->dev.of_node);
563-
564-
return 0;
565563
}
566564

567565
static const struct of_device_id axi_clkgen_ids[] = {
@@ -583,7 +581,7 @@ static struct platform_driver axi_clkgen_driver = {
583581
.of_match_table = axi_clkgen_ids,
584582
},
585583
.probe = axi_clkgen_probe,
586-
.remove = axi_clkgen_remove,
584+
.remove_new = axi_clkgen_remove,
587585
};
588586
module_platform_driver(axi_clkgen_driver);
589587

0 commit comments

Comments
 (0)