Skip to content

Commit 78012e3

Browse files
Uwe Kleine-Königdlezcano
authored andcommitted
clocksource/drivers/sh_mtu2: Mark driver as non-removable
The comment in the remove callback suggests that the driver is not supposed to be unbound. However returning an error code in the remove callback doesn't accomplish that. Instead set the suppress_bind_attrs property (which makes it impossible to unbind the driver via sysfs). The only remaining way to unbind a sh_tmu2 device would be module unloading, but that doesn't apply here, as the driver cannot be built as a module. Also drop the useless remove callback. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20230313075430.2730803-2-u.kleine-koenig@pengutronix.de
1 parent 0fabf9f commit 78012e3

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

drivers/clocksource/sh_mtu2.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -484,11 +484,6 @@ static int sh_mtu2_probe(struct platform_device *pdev)
484484
return 0;
485485
}
486486

487-
static int sh_mtu2_remove(struct platform_device *pdev)
488-
{
489-
return -EBUSY; /* cannot unregister clockevent */
490-
}
491-
492487
static const struct platform_device_id sh_mtu2_id_table[] = {
493488
{ "sh-mtu2", 0 },
494489
{ },
@@ -503,10 +498,10 @@ MODULE_DEVICE_TABLE(of, sh_mtu2_of_table);
503498

504499
static struct platform_driver sh_mtu2_device_driver = {
505500
.probe = sh_mtu2_probe,
506-
.remove = sh_mtu2_remove,
507501
.driver = {
508502
.name = "sh_mtu2",
509503
.of_match_table = of_match_ptr(sh_mtu2_of_table),
504+
.suppress_bind_attrs = true,
510505
},
511506
.id_table = sh_mtu2_id_table,
512507
};

0 commit comments

Comments
 (0)