Skip to content

Commit 7865370

Browse files
jbroadusJiri Kosina
authored andcommitted
HID: i2c-hid: Fix Elan touchpad regression
A quirk was recently added for Elan devices that has same device match as an entry earlier in the list. The i2c_hid_lookup_quirk function will always return the last match in the list, so the new entry shadows the old entry. The quirk in the previous entry, I2C_HID_QUIRK_BOGUS_IRQ, silenced a flood of messages which have reappeared in the 5.13 kernel. This change moves the two quirk flags into the same entry. Fixes: ca66a67 (HID: i2c-hid: Skip ELAN power-on command after reset) Signed-off-by: Jim Broadus <jbroadus@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent 87c7ee7 commit 7865370

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/hid/i2c-hid/i2c-hid-core.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,6 @@ static const struct i2c_hid_quirks {
171171
I2C_HID_QUIRK_NO_IRQ_AFTER_RESET },
172172
{ I2C_VENDOR_ID_RAYDIUM, I2C_PRODUCT_ID_RAYDIUM_3118,
173173
I2C_HID_QUIRK_NO_IRQ_AFTER_RESET },
174-
{ USB_VENDOR_ID_ELAN, HID_ANY_ID,
175-
I2C_HID_QUIRK_BOGUS_IRQ },
176174
{ USB_VENDOR_ID_ALPS_JP, HID_ANY_ID,
177175
I2C_HID_QUIRK_RESET_ON_RESUME },
178176
{ I2C_VENDOR_ID_SYNAPTICS, I2C_PRODUCT_ID_SYNAPTICS_SYNA2393,
@@ -183,7 +181,8 @@ static const struct i2c_hid_quirks {
183181
* Sending the wakeup after reset actually break ELAN touchscreen controller
184182
*/
185183
{ USB_VENDOR_ID_ELAN, HID_ANY_ID,
186-
I2C_HID_QUIRK_NO_WAKEUP_AFTER_RESET },
184+
I2C_HID_QUIRK_NO_WAKEUP_AFTER_RESET |
185+
I2C_HID_QUIRK_BOGUS_IRQ },
187186
{ 0, 0 }
188187
};
189188

0 commit comments

Comments
 (0)