Skip to content

Commit 78a2bb4

Browse files
Uwe Kleine-Königlag-linaro
authored andcommitted
backlight: da9052_bl: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230308073945.2336302-5-u.kleine-koenig@pengutronix.de
1 parent f6672d7 commit 78a2bb4

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/video/backlight/da9052_bl.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,16 +135,14 @@ static int da9052_backlight_probe(struct platform_device *pdev)
135135
return da9052_adjust_wled_brightness(wleds);
136136
}
137137

138-
static int da9052_backlight_remove(struct platform_device *pdev)
138+
static void da9052_backlight_remove(struct platform_device *pdev)
139139
{
140140
struct backlight_device *bl = platform_get_drvdata(pdev);
141141
struct da9052_bl *wleds = bl_get_data(bl);
142142

143143
wleds->brightness = 0;
144144
wleds->state = DA9052_WLEDS_OFF;
145145
da9052_adjust_wled_brightness(wleds);
146-
147-
return 0;
148146
}
149147

150148
static const struct platform_device_id da9052_wled_ids[] = {
@@ -166,7 +164,7 @@ MODULE_DEVICE_TABLE(platform, da9052_wled_ids);
166164

167165
static struct platform_driver da9052_wled_driver = {
168166
.probe = da9052_backlight_probe,
169-
.remove = da9052_backlight_remove,
167+
.remove_new = da9052_backlight_remove,
170168
.id_table = da9052_wled_ids,
171169
.driver = {
172170
.name = "da9052-wled",

0 commit comments

Comments
 (0)