Skip to content

Commit 78a2f2a

Browse files
konradybcioandersson
authored andcommitted
clk: qcom: gcc-msm8996: Update the .pwrsts for usb gdsc
The USB controller on MSM8996 doesn't retain its state when the system goes into low power state and the GDSCs are turned off. This can be observed by the USB connection not coming back alive after putting the device into suspend, essentially breaking USB. Work around this by updating the .pwrsts for the USB GDSCs so they only transition to retention state in low power. This change should be reverted when a proper suspend sequence is implemented in the USB drivers. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20230307123159.3797551-2-konrad.dybcio@linaro.org
1 parent 03b4948 commit 78a2f2a

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/clk/qcom/gcc-msm8996.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3455,7 +3455,8 @@ static struct gdsc usb30_gdsc = {
34553455
.pd = {
34563456
.name = "usb30",
34573457
},
3458-
.pwrsts = PWRSTS_OFF_ON,
3458+
/* TODO: Change to OFF_ON when USB drivers get proper suspend support */
3459+
.pwrsts = PWRSTS_RET_ON,
34593460
};
34603461

34613462
static struct gdsc pcie0_gdsc = {

0 commit comments

Comments
 (0)