Skip to content

Commit 7915f42

Browse files
committed
firmware: avoid pointless reference count bump
The creds are allocated via prepare_kernel_cred() which has already taken a reference. Link: https://lore.kernel.org/r/20241125-work-cred-v2-7-68b9d38bb5b2@kernel.org Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 51c0bcf commit 7915f42

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • drivers/base/firmware_loader

drivers/base/firmware_loader/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -911,7 +911,7 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
911911
ret = -ENOMEM;
912912
goto out;
913913
}
914-
old_cred = override_creds(get_new_cred(kern_cred));
914+
old_cred = override_creds(kern_cred);
915915

916916
ret = fw_get_filesystem_firmware(device, fw->priv, "", NULL);
917917

@@ -943,7 +943,7 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
943943
} else
944944
ret = assign_fw(fw, device);
945945

946-
put_cred(revert_creds(old_cred));
946+
revert_creds(old_cred);
947947
put_cred(kern_cred);
948948

949949
out:

0 commit comments

Comments
 (0)