Skip to content

Commit 7937609

Browse files
krzkkuba-moo
authored andcommitted
nfc: nci: fix possible NULL pointer dereference in send_acknowledge()
Handle memory allocation failure from nci_skb_alloc() (calling alloc_skb()) to avoid possible NULL pointer dereference. Reported-by: 黄思聪 <huangsicong@iie.ac.cn> Fixes: 391d8a2 ("NFC: Add NCI over SPI receive") Cc: <stable@vger.kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20231013184129.18738-1-krzysztof.kozlowski@linaro.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 503930f commit 7937609

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

net/nfc/nci/spi.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,8 @@ static int send_acknowledge(struct nci_spi *nspi, u8 acknowledge)
151151
int ret;
152152

153153
skb = nci_skb_alloc(nspi->ndev, 0, GFP_KERNEL);
154+
if (!skb)
155+
return -ENOMEM;
154156

155157
/* add the NCI SPI header to the start of the buffer */
156158
hdr = skb_push(skb, NCI_SPI_HDR_LEN);

0 commit comments

Comments
 (0)