backlight: hx8357: Use of_property_present() for testing DT property presence

robherring · lag-linaro · commit 796bf946c426 · 2023-03-16T16:12:27.000Z
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more. Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230310144730.1546101-1-robh@kernel.org
diff --git a/drivers/video/backlight/hx8357.c b/drivers/video/backlight/hx8357.c
@@ -617,7 +617,7 @@ static int hx8357_probe(struct spi_device *spi)
 		return -EINVAL;
 	}
 
-	if (of_find_property(spi->dev.of_node, "im-gpios", NULL)) {
+	if (of_property_present(spi->dev.of_node, "im-gpios")) {
 		lcd->use_im_pins = 1;
 
 		for (i = 0; i < HX8357_NUM_IM_PINS; i++) {

Original file line number	Diff line number	Diff line change
`@@ -617,7 +617,7 @@ static int hx8357_probe(struct spi_device *spi)`
`617`	`617`	`return -EINVAL;`
`618`	`618`	`}`
`619`	`619`
`620`		`- if (of_find_property(spi->dev.of_node, "im-gpios", NULL)) {`
	`620`	`+ if (of_property_present(spi->dev.of_node, "im-gpios")) {`
`621`	`621`	`lcd->use_im_pins = 1;`
`622`	`622`
`623`	`623`	`for (i = 0; i < HX8357_NUM_IM_PINS; i++) {`