Skip to content

Commit 7a1aba8

Browse files
kubalewskianguy11
authored andcommitted
ice: dpll: fix initial lock status of dpll
When dpll device is registered and dpll subsystem performs notify of a new device, the lock state value provided to dpll subsystem equals 0 which is invalid value for the `enum dpll_lock_status`. Provide correct value by obtaining it from firmware before registering the dpll device. Fixes: d7999f5 ("ice: implement dpll interface to control cgu") Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent c0a2a1b commit 7a1aba8

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/net/ethernet/intel/ice/ice_dpll.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1756,6 +1756,7 @@ ice_dpll_init_dpll(struct ice_pf *pf, struct ice_dpll *d, bool cgu,
17561756
}
17571757
d->pf = pf;
17581758
if (cgu) {
1759+
ice_dpll_update_state(pf, d, true);
17591760
ret = dpll_device_register(d->dpll, type, &ice_dpll_ops, d);
17601761
if (ret) {
17611762
dpll_device_put(d->dpll);
@@ -1796,8 +1797,6 @@ static int ice_dpll_init_worker(struct ice_pf *pf)
17961797
struct ice_dplls *d = &pf->dplls;
17971798
struct kthread_worker *kworker;
17981799

1799-
ice_dpll_update_state(pf, &d->eec, true);
1800-
ice_dpll_update_state(pf, &d->pps, true);
18011800
kthread_init_delayed_work(&d->work, ice_dpll_periodic_work);
18021801
kworker = kthread_create_worker(0, "ice-dplls-%s",
18031802
dev_name(ice_pf_to_dev(pf)));

0 commit comments

Comments
 (0)