Skip to content

Commit 7a6b3d8

Browse files
cpackham-atlnzWim Van Sebroeck
authored andcommitted
watchdog: orion_wdt: support pretimeout on Armada-XP
Commit e07a4c7 ("watchdog: orion_wdt: use timer1 as a pretimeout") added support for a pretimeout on Armada-38x variants. Because the Armada-XP variants use armada370_start/armada370_stop (due to missing an explicit RSTOUT mask bit for the watchdog). Add the required pretimeout support to armada370_start/armada370_stop for Armada-XP. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20220211003257.2037332-3-chris.packham@alliedtelesis.co.nz Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
1 parent cd91fb2 commit 7a6b3d8

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

drivers/watchdog/orion_wdt.c

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,10 @@ static int armada370_start(struct watchdog_device *wdt_dev)
238238
atomic_io_modify(dev->reg + TIMER_A370_STATUS, WDT_A370_EXPIRED, 0);
239239

240240
/* Enable watchdog timer */
241-
atomic_io_modify(dev->reg + TIMER_CTRL, dev->data->wdt_enable_bit,
242-
dev->data->wdt_enable_bit);
241+
reg = dev->data->wdt_enable_bit;
242+
if (dev->wdt.info->options & WDIOF_PRETIMEOUT)
243+
reg |= TIMER1_ENABLE_BIT;
244+
atomic_io_modify(dev->reg + TIMER_CTRL, reg, reg);
243245

244246
/* Enable reset on watchdog */
245247
reg = readl(dev->rstout);
@@ -312,15 +314,18 @@ static int armada375_stop(struct watchdog_device *wdt_dev)
312314
static int armada370_stop(struct watchdog_device *wdt_dev)
313315
{
314316
struct orion_watchdog *dev = watchdog_get_drvdata(wdt_dev);
315-
u32 reg;
317+
u32 reg, mask;
316318

317319
/* Disable reset on watchdog */
318320
reg = readl(dev->rstout);
319321
reg &= ~dev->data->rstout_enable_bit;
320322
writel(reg, dev->rstout);
321323

322324
/* Disable watchdog timer */
323-
atomic_io_modify(dev->reg + TIMER_CTRL, dev->data->wdt_enable_bit, 0);
325+
mask = dev->data->wdt_enable_bit;
326+
if (wdt_dev->info->options & WDIOF_PRETIMEOUT)
327+
mask |= TIMER1_ENABLE_BIT;
328+
atomic_io_modify(dev->reg + TIMER_CTRL, mask, 0);
324329

325330
return 0;
326331
}

0 commit comments

Comments
 (0)