Skip to content

Commit 7aa234e

Browse files
Uwe Kleine-Königrafaeljw
authored andcommitted
thermal: dove: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 0d0f8b2 commit 7aa234e

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/thermal/dove_thermal.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,21 +158,19 @@ static int dove_thermal_probe(struct platform_device *pdev)
158158
return 0;
159159
}
160160

161-
static int dove_thermal_exit(struct platform_device *pdev)
161+
static void dove_thermal_exit(struct platform_device *pdev)
162162
{
163163
struct thermal_zone_device *dove_thermal =
164164
platform_get_drvdata(pdev);
165165

166166
thermal_zone_device_unregister(dove_thermal);
167-
168-
return 0;
169167
}
170168

171169
MODULE_DEVICE_TABLE(of, dove_thermal_id_table);
172170

173171
static struct platform_driver dove_thermal_driver = {
174172
.probe = dove_thermal_probe,
175-
.remove = dove_thermal_exit,
173+
.remove_new = dove_thermal_exit,
176174
.driver = {
177175
.name = "dove_thermal",
178176
.of_match_table = dove_thermal_id_table,

0 commit comments

Comments
 (0)