Skip to content

Commit 7abbf38

Browse files
Geliang TangMartin KaFai Lau
authored andcommitted
selftests/bpf: Drop get_port in test_tcp_check_syncookie
The arguments "addr" and "len" of run_test() have dropped. This makes function get_port() useless. Drop it from test_tcp_check_syncookie_user.c. Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn> Link: https://lore.kernel.org/r/a9b5c8064ab4cbf0f68886fe0e4706428b8d0d47.1714907662.git.tanggeliang@kylinos.cn Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
1 parent 65a3f0d commit 7abbf38

1 file changed

Lines changed: 3 additions & 18 deletions

File tree

tools/testing/selftests/bpf/test_tcp_check_syncookie_user.c

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -139,21 +139,6 @@ static int run_test(int server_fd, int results_fd, bool xdp)
139139
return ret;
140140
}
141141

142-
static bool get_port(int server_fd, in_port_t *port)
143-
{
144-
struct sockaddr_in addr;
145-
socklen_t len = sizeof(addr);
146-
147-
if (getsockname(server_fd, (struct sockaddr *)&addr, &len)) {
148-
log_err("Failed to get server addr");
149-
return false;
150-
}
151-
152-
/* sin_port and sin6_port are located at the same offset. */
153-
*port = addr.sin_port;
154-
return true;
155-
}
156-
157142
static int v6only_true(int fd, const struct post_socket_opts *opts)
158143
{
159144
int mode = true;
@@ -214,19 +199,19 @@ int main(int argc, char **argv)
214199

215200
server = start_server_addr(SOCK_STREAM, (struct sockaddr_storage *)&addr4,
216201
sizeof(addr4), NULL);
217-
if (server == -1 || !get_port(server, &addr4.sin_port))
202+
if (server == -1)
218203
goto err;
219204

220205
opts.post_socket_cb = v6only_true;
221206
server_v6 = start_server_addr(SOCK_STREAM, (struct sockaddr_storage *)&addr6,
222207
sizeof(addr6), &opts);
223-
if (server_v6 == -1 || !get_port(server_v6, &addr6.sin6_port))
208+
if (server_v6 == -1)
224209
goto err;
225210

226211
opts.post_socket_cb = v6only_false;
227212
server_dual = start_server_addr(SOCK_STREAM, (struct sockaddr_storage *)&addr6dual,
228213
sizeof(addr6dual), &opts);
229-
if (server_dual == -1 || !get_port(server_dual, &addr4dual.sin_port))
214+
if (server_dual == -1)
230215
goto err;
231216

232217
if (run_test(server, results, xdp))

0 commit comments

Comments
 (0)