Skip to content

Commit 7adde5a

Browse files
Yuan Canmiquelraynal
authored andcommitted
mtd: parsers: Fix potential memory leak in mtd_parser_tplink_safeloader_parse()
The parts needs to be freed with all its elements, otherwise it will be leaked. Fixes: 00a3588 ("mtd: parsers: add TP-Link SafeLoader partitions table parser") Signed-off-by: Yuan Can <yuancan@huawei.com> Reviewed-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20221208113620.78855-1-yuancan@huawei.com
1 parent 88603b6 commit 7adde5a

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/mtd/parsers/tplink_safeloader.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ static int mtd_parser_tplink_safeloader_parse(struct mtd_info *mtd,
9191
buf = mtd_parser_tplink_safeloader_read_table(mtd);
9292
if (!buf) {
9393
err = -ENOENT;
94-
goto err_out;
94+
goto err_free_parts;
9595
}
9696

9797
for (idx = 0, offset = TPLINK_SAFELOADER_DATA_OFFSET;
@@ -118,6 +118,8 @@ static int mtd_parser_tplink_safeloader_parse(struct mtd_info *mtd,
118118
err_free:
119119
for (idx -= 1; idx >= 0; idx--)
120120
kfree(parts[idx].name);
121+
err_free_parts:
122+
kfree(parts);
121123
err_out:
122124
return err;
123125
};

0 commit comments

Comments
 (0)