Skip to content

Commit 7afbe5d

Browse files
azeemshaikh38kees
authored andcommitted
scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] KSPP#89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230517142955.1519572-1-azeemshaikh38@gmail.com
1 parent 038d40e commit 7afbe5d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/scsi/3w-9xxx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,7 @@ static int twa_check_srl(TW_Device_Extension *tw_dev, int *flashed)
617617
}
618618

619619
/* Load rest of compatibility struct */
620-
strlcpy(tw_dev->tw_compat_info.driver_version, TW_DRIVER_VERSION,
620+
strscpy(tw_dev->tw_compat_info.driver_version, TW_DRIVER_VERSION,
621621
sizeof(tw_dev->tw_compat_info.driver_version));
622622
tw_dev->tw_compat_info.driver_srl_high = TW_CURRENT_DRIVER_SRL;
623623
tw_dev->tw_compat_info.driver_branch_high = TW_CURRENT_DRIVER_BRANCH;

0 commit comments

Comments
 (0)