Skip to content

Commit 7b1ae24

Browse files
Shuo Chengregkh
authored andcommitted
dyndbg: fix parsing file query without a line-range suffix
Query like 'file tcp_input.c line 1234 +p' was broken by commit aaebe32 ("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'") because a file name without a ':' now makes the loop in ddebug_parse_query() exits early before parsing the 'line 1234' part. As a result, all pr_debug() in tcp_input.c will be enabled, instead of only the one on line 1234. Changing 'break' to 'continue' fixes this. Fixes: aaebe32 ("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'") Cc: stable <stable@vger.kernel.org> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Shuo Chen <shuochen@google.com> Acked-by: Jason Baron <jbaron@akamai.com> Link: https://lore.kernel.org/r/20210414212400.2927281-1-giantchen@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f1ce398 commit 7b1ae24

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

lib/dynamic_debug.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ static int ddebug_parse_query(char *words[], int nwords,
396396
/* tail :$info is function or line-range */
397397
fline = strchr(query->filename, ':');
398398
if (!fline)
399-
break;
399+
continue;
400400
*fline++ = '\0';
401401
if (isalpha(*fline) || *fline == '*' || *fline == '?') {
402402
/* take as function name */

0 commit comments

Comments
 (0)