Skip to content

Commit 7b490a8

Browse files
Menglong Dongtsbogend
authored andcommitted
MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu
The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0' can't be true. Fix this by change the type of 'r' and 'i' from 'unsigned int' to 'int'. As 'i' won't be negative, this change works. Fixes: 99fbc70 ("MIPS: Octeon: irq: Alloc desc before configuring IRQ") Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
1 parent 69e9768 commit 7b490a8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/mips/cavium-octeon/octeon-irq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1444,7 +1444,7 @@ static void octeon_irq_setup_secondary_ciu2(void)
14441444
static int __init octeon_irq_init_ciu(
14451445
struct device_node *ciu_node, struct device_node *parent)
14461446
{
1447-
unsigned int i, r;
1447+
int i, r;
14481448
struct irq_chip *chip;
14491449
struct irq_chip *chip_edge;
14501450
struct irq_chip *chip_mbox;

0 commit comments

Comments
 (0)