can: rcar_canfd: Add missing of_node_put() in rcar_canfd_probe()

windhl · marckleinebudde · commit 7b66dfcc6e1e · 2022-07-20T10:20:19.000+02:00
We should use of_node_put() for the reference returned by of_get_child_by_name() which has increased the refcount. Fixes: 45721c4 ("can: rcar_canfd: Add support for r8a779a0 SoC") Link: https://lore.kernel.org/all/20220712095623.364287-1-windhl@126.com Signed-off-by: Liang He <windhl@126.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
@@ -1843,6 +1843,7 @@ static int rcar_canfd_probe(struct platform_device *pdev)
 		of_child = of_get_child_by_name(pdev->dev.of_node, name);
 		if (of_child && of_device_is_available(of_child))
 			channels_mask |= BIT(i);
+		of_node_put(of_child);
 	}
 
 	if (chip_id != RENESAS_RZG2L) {

Original file line number	Diff line number	Diff line change
`@@ -1843,6 +1843,7 @@ static int rcar_canfd_probe(struct platform_device *pdev)`
`1843`	`1843`	`of_child = of_get_child_by_name(pdev->dev.of_node, name);`
`1844`	`1844`	`if (of_child && of_device_is_available(of_child))`
`1845`	`1845`	`channels_mask \|= BIT(i);`
	`1846`	`+ of_node_put(of_child);`
`1846`	`1847`	`}`
`1847`	`1848`
`1848`	`1849`	`if (chip_id != RENESAS_RZG2L) {`