Skip to content

Commit 7b6f9d9

Browse files
Yuxiong Wangdavejiang
authored andcommitted
cxl: Fix premature commit_end increment on decoder commit failure
In cxl_decoder_commit(), commit_end is incremented before verifying whether the commit succeeded, and the CXL_DECODER_F_ENABLE bit in cxld->flags is only set after a successful commit. As a result, if the commit fails, commit_end has been incremented and cxld->reset() has no effect since the flag is not set, so commit_end remains incorrectly incremented. The inconsistency between commit_end and CXL_DECODER_F_ENABLE causes failure during subsequent either commit or reset operations. Fix this by incrementing commit_end only after confirming the commit succeeded. Also, remove the ineffective cxld->reset() call. According to CXL Spec r4.0 8.2.4.20.12 Committing Decoder Programming, since cxld_await_commit() has cleared the decoder commit bit on failure, no additional reset is required. [dj: Fixed commit log 80 char wrapping. ] [dj: Fix "Fixes" tag to correct hash length. ] [dj: Change spec to r4.0. ] Fixes: 176baef ("cxl/hdm: Commit decoder state to hardware") Signed-off-by: Yuxiong Wang <yuxiong.wang@linux.alibaba.com> Acked-by: Huang Ying <ying.huang@linux.alibaba.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Alison Schofield <alison.schofield@intel.com> Link: https://patch.msgid.link/20260129064552.31180-1-yuxiong.wang@linux.alibaba.com Signed-off-by: Dave Jiang <dave.jiang@intel.com>
1 parent 064c098 commit 7b6f9d9

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/cxl/core/hdm.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -844,14 +844,13 @@ static int cxl_decoder_commit(struct cxl_decoder *cxld)
844844
scoped_guard(rwsem_read, &cxl_rwsem.dpa)
845845
setup_hw_decoder(cxld, hdm);
846846

847-
port->commit_end++;
848847
rc = cxld_await_commit(hdm, cxld->id);
849848
if (rc) {
850849
dev_dbg(&port->dev, "%s: error %d committing decoder\n",
851850
dev_name(&cxld->dev), rc);
852-
cxld->reset(cxld);
853851
return rc;
854852
}
853+
port->commit_end++;
855854
cxld->flags |= CXL_DECODER_F_ENABLE;
856855

857856
return 0;

0 commit comments

Comments
 (0)