drm/panel: raspberrypi-touchscreen: Prevent double-free

mripard · mripard · commit 7bbcb919e32d · 2021-07-22T11:37:03.000+02:00
The mipi_dsi_device allocated by mipi_dsi_device_register_full() is already free'd on release. Fixes: 2f733d6 ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.") Signed-off-by: Maxime Ripard <maxime@cerno.tech> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20210720134525.563936-9-maxime@cerno.tech
diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
@@ -447,7 +447,6 @@ static int rpi_touchscreen_remove(struct i2c_client *i2c)
 	drm_panel_remove(&ts->base);
 
 	mipi_dsi_device_unregister(ts->dsi);
-	kfree(ts->dsi);
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -447,7 +447,6 @@ static int rpi_touchscreen_remove(struct i2c_client *i2c)`
`447`	`447`	`drm_panel_remove(&ts->base);`
`448`	`448`
`449`	`449`	`mipi_dsi_device_unregister(ts->dsi);`
`450`		`- kfree(ts->dsi);`
`451`	`450`
`452`	`451`	`return 0;`
`453`	`452`	`}`