Skip to content

Commit 7c74660

Browse files
ukleinekJiri Kosina
authored andcommitted
HID: intel-ish-hid: Simplify logic in ishtp_cl_device_remove()
There is only a single change in behavior: Now dev->driver isn't modified. Assigning to this variable is in the domain of the driver core only. (And it's done in __device_release_driver shortly after bus->remove() (i.e ishtp_cl_device_remove() here) returns.) Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent 464956f commit 7c74660

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

  • drivers/hid/intel-ish-hid/ishtp

drivers/hid/intel-ish-hid/ishtp/bus.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -258,19 +258,17 @@ static int ishtp_cl_device_remove(struct device *dev)
258258
{
259259
struct ishtp_cl_device *device = to_ishtp_cl_device(dev);
260260
struct ishtp_cl_driver *driver = to_ishtp_cl_driver(dev->driver);
261+
int ret = 0;
261262

262263
if (device->event_cb) {
263264
device->event_cb = NULL;
264265
cancel_work_sync(&device->event_work);
265266
}
266267

267-
if (!driver->remove) {
268-
dev->driver = NULL;
268+
if (driver->remove)
269+
ret = driver->remove(device);
269270

270-
return 0;
271-
}
272-
273-
return driver->remove(device);
271+
return ret;
274272
}
275273

276274
/**

0 commit comments

Comments
 (0)