Skip to content

Commit 7cce65f

Browse files
committed
drm/ast: Fix comment on modeset lock
The ast driver protects the commit tail against concurrent reads of the display modes by acquiring a lock. The comment is misleading as the lock is not released in atomic_flush, but at the end of the commit-tail helper. Rewrite the comment. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: 1fe1821 ("drm/ast: Acquire I/O-register lock in atomic_commit_tail function") Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Jocelyn Falempe <jfalempe@redhat.com> Cc: Dave Airlie <airlied@redhat.com> Cc: dri-devel@lists.freedesktop.org Cc: <stable@vger.kernel.org> # v6.2+ Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> Link: https://lore.kernel.org/r/20250324094520.192974-2-tzimmermann@suse.de
1 parent 231aded commit 7cce65f

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/gpu/drm/ast/ast_mode.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -939,9 +939,9 @@ static void ast_mode_config_helper_atomic_commit_tail(struct drm_atomic_state *s
939939

940940
/*
941941
* Concurrent operations could possibly trigger a call to
942-
* drm_connector_helper_funcs.get_modes by trying to read the
943-
* display modes. Protect access to I/O registers by acquiring
944-
* the I/O-register lock. Released in atomic_flush().
942+
* drm_connector_helper_funcs.get_modes by reading the display
943+
* modes. Protect access to registers by acquiring the modeset
944+
* lock.
945945
*/
946946
mutex_lock(&ast->modeset_lock);
947947
drm_atomic_helper_commit_tail(state);

0 commit comments

Comments
 (0)