Skip to content

Commit 7cefbe5

Browse files
Paolo Abenikuba-moo
authored andcommitted
selftests: mptcp: fix fastclose with csum failure
Running the mp_join selftest manually with the following command line: ./mptcp_join.sh -z -C leads to some failures: 002 fastclose server test # ... rtx [fail] got 1 MP_RST[s] TX expected 0 # ... rstrx [fail] got 1 MP_RST[s] RX expected 0 The problem is really in the wrong expectations for the RST checks implied by the csum validation. Note that the same check is repeated explicitly in the same test-case, with the correct expectation and pass successfully. Address the issue explicitly setting the correct expectation for the failing checks. Reported-by: Xiumei Mu <xmu@redhat.com> Fixes: 6bf4102 ("selftests: mptcp: update and extend fastclose test-cases") Cc: stable@vger.kernel.org Signed-off-by: Paolo Abeni <pabeni@redhat.com> Reviewed-by: Matthieu Baerts <matttbe@kernel.org> Signed-off-by: Matthieu Baerts <matttbe@kernel.org> Link: https://lore.kernel.org/r/20231114-upstream-net-20231113-mptcp-misc-fixes-6-7-rc2-v1-5-7b9cd6a7b7f4@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 7679d34 commit 7cefbe5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3240,7 +3240,7 @@ fastclose_tests()
32403240
if reset_check_counter "fastclose server test" "MPTcpExtMPFastcloseRx"; then
32413241
test_linkfail=1024 fastclose=server \
32423242
run_tests $ns1 $ns2 10.0.1.1
3243-
chk_join_nr 0 0 0
3243+
chk_join_nr 0 0 0 0 0 0 1
32443244
chk_fclose_nr 1 1 invert
32453245
chk_rst_nr 1 1
32463246
fi

0 commit comments

Comments
 (0)