Skip to content

Commit 7d21296

Browse files
KobyElbazogabbay
authored andcommitted
accel/habanalabs: fix a static warning - 'dubious: x & !y'
Use a straight forward approach to get a conditional result. Signed-off-by: Koby Elbaz <kelbaz@habana.ai> Reviewed-by: Oded Gabbay <ogabbay@kernel.org> Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
1 parent 67d19a2 commit 7d21296

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/accel/habanalabs/gaudi2/gaudi2.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4527,7 +4527,7 @@ static int gaudi2_set_tpc_engine_mode(struct hl_device *hdev, u32 engine_id, u32
45274527
reg_base = gaudi2_tpc_cfg_blocks_bases[tpc_id];
45284528
reg_addr = reg_base + TPC_CFG_STALL_OFFSET;
45294529
reg_val = FIELD_PREP(DCORE0_TPC0_CFG_TPC_STALL_V_MASK,
4530-
!!(engine_command == HL_ENGINE_STALL));
4530+
(engine_command == HL_ENGINE_STALL) ? 1 : 0);
45314531
WREG32(reg_addr, reg_val);
45324532

45334533
if (engine_command == HL_ENGINE_RESUME) {
@@ -4551,7 +4551,7 @@ static int gaudi2_set_mme_engine_mode(struct hl_device *hdev, u32 engine_id, u32
45514551
reg_base = gaudi2_mme_ctrl_lo_blocks_bases[mme_id];
45524552
reg_addr = reg_base + MME_CTRL_LO_QM_STALL_OFFSET;
45534553
reg_val = FIELD_PREP(DCORE0_MME_CTRL_LO_QM_STALL_V_MASK,
4554-
!!(engine_command == HL_ENGINE_STALL));
4554+
(engine_command == HL_ENGINE_STALL) ? 1 : 0);
45554555
WREG32(reg_addr, reg_val);
45564556

45574557
return 0;
@@ -4572,7 +4572,7 @@ static int gaudi2_set_edma_engine_mode(struct hl_device *hdev, u32 engine_id, u3
45724572
reg_base = gaudi2_dma_core_blocks_bases[edma_id];
45734573
reg_addr = reg_base + EDMA_CORE_CFG_STALL_OFFSET;
45744574
reg_val = FIELD_PREP(DCORE0_EDMA0_CORE_CFG_1_HALT_MASK,
4575-
!!(engine_command == HL_ENGINE_STALL));
4575+
(engine_command == HL_ENGINE_STALL) ? 1 : 0);
45764576
WREG32(reg_addr, reg_val);
45774577

45784578
if (engine_command == HL_ENGINE_STALL) {

0 commit comments

Comments
 (0)