kconfig: use linked list in sym_set_changed()

masahir0y · masahir0y · commit 7d2806746d46 · 2024-05-10T04:34:52.000+09:00
Following the approach employed in commit bedf923 ("kconfig: use linked list in get_symbol_str() to iterate over menus"), simplify the iteration on the menus of the specified symbol. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
@@ -152,13 +152,11 @@ static void sym_validate_range(struct symbol *sym)
 
 static void sym_set_changed(struct symbol *sym)
 {
-	struct property *prop;
+	struct menu *menu;
 
 	sym->flags |= SYMBOL_CHANGED;
-	for (prop = sym->prop; prop; prop = prop->next) {
-		if (prop->menu)
-			prop->menu->flags |= MENU_CHANGED;
-	}
+	list_for_each_entry(menu, &sym->menus, link)
+		menu->flags |= MENU_CHANGED;
 }
 
 static void sym_set_all_changed(void)

Original file line number	Diff line number	Diff line change
`@@ -152,13 +152,11 @@ static void sym_validate_range(struct symbol *sym)`
`152`	`152`
`153`	`153`	`static void sym_set_changed(struct symbol *sym)`
`154`	`154`	`{`
`155`		`- struct property *prop;`
	`155`	`+ struct menu *menu;`
`156`	`156`
`157`	`157`	`sym->flags \|= SYMBOL_CHANGED;`
`158`		`- for (prop = sym->prop; prop; prop = prop->next) {`
`159`		`- if (prop->menu)`
`160`		`- prop->menu->flags \|= MENU_CHANGED;`
`161`		`- }`
	`158`	`+ list_for_each_entry(menu, &sym->menus, link)`
	`159`	`+ menu->flags \|= MENU_CHANGED;`
`162`	`160`	`}`
`163`	`161`
`164`	`162`	`static void sym_set_all_changed(void)`