Skip to content

Commit 7d28f13

Browse files
Matthew Wilcox (Oracle)Jaegeuk Kim
authored andcommitted
f2fs: Pass a folio to get_dnode_addr()
All callers except __get_inode_rdev() and __set_inode_rdev() now have a folio, but the only callers of those two functions do have a folio, so pass the folio to them and then into get_dnode_addr(). Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Reviewed-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent 6f7ec66 commit 7d28f13

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

fs/f2fs/data.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1116,7 +1116,7 @@ static int f2fs_submit_page_read(struct inode *inode, struct folio *folio,
11161116

11171117
static void __set_data_blkaddr(struct dnode_of_data *dn, block_t blkaddr)
11181118
{
1119-
__le32 *addr = get_dnode_addr(dn->inode, &dn->node_folio->page);
1119+
__le32 *addr = get_dnode_addr(dn->inode, dn->node_folio);
11201120

11211121
dn->data_blkaddr = blkaddr;
11221122
addr[dn->ofs_in_node] = cpu_to_le32(dn->data_blkaddr);

fs/f2fs/f2fs.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3033,16 +3033,16 @@ static inline unsigned int get_dnode_base(struct inode *inode,
30333033
}
30343034

30353035
static inline __le32 *get_dnode_addr(struct inode *inode,
3036-
struct page *node_page)
3036+
struct folio *node_folio)
30373037
{
3038-
return blkaddr_in_node(F2FS_NODE(node_page)) +
3039-
get_dnode_base(inode, node_page);
3038+
return blkaddr_in_node(F2FS_NODE(&node_folio->page)) +
3039+
get_dnode_base(inode, &node_folio->page);
30403040
}
30413041

30423042
static inline block_t data_blkaddr(struct inode *inode,
30433043
struct folio *node_folio, unsigned int offset)
30443044
{
3045-
return le32_to_cpu(*(get_dnode_addr(inode, &node_folio->page) + offset));
3045+
return le32_to_cpu(*(get_dnode_addr(inode, node_folio) + offset));
30463046
}
30473047

30483048
static inline block_t f2fs_data_blkaddr(struct dnode_of_data *dn)
@@ -3409,7 +3409,7 @@ static inline bool f2fs_is_cow_file(struct inode *inode)
34093409

34103410
static inline void *inline_data_addr(struct inode *inode, struct folio *folio)
34113411
{
3412-
__le32 *addr = get_dnode_addr(inode, &folio->page);
3412+
__le32 *addr = get_dnode_addr(inode, folio);
34133413

34143414
return (void *)(addr + DEF_INLINE_RESERVED_SIZE);
34153415
}

fs/f2fs/file.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ void f2fs_truncate_data_blocks_range(struct dnode_of_data *dn, int count)
628628
block_t blkstart;
629629
int blklen = 0;
630630

631-
addr = get_dnode_addr(dn->inode, &dn->node_folio->page) + ofs;
631+
addr = get_dnode_addr(dn->inode, dn->node_folio) + ofs;
632632
blkstart = le32_to_cpu(*addr);
633633

634634
/* Assumption: truncation starts with cluster */

fs/f2fs/inode.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ void f2fs_set_inode_flags(struct inode *inode)
6868
S_ENCRYPTED|S_VERITY|S_CASEFOLD);
6969
}
7070

71-
static void __get_inode_rdev(struct inode *inode, struct page *node_page)
71+
static void __get_inode_rdev(struct inode *inode, struct folio *node_folio)
7272
{
73-
__le32 *addr = get_dnode_addr(inode, node_page);
73+
__le32 *addr = get_dnode_addr(inode, node_folio);
7474

7575
if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode) ||
7676
S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) {
@@ -81,9 +81,9 @@ static void __get_inode_rdev(struct inode *inode, struct page *node_page)
8181
}
8282
}
8383

84-
static void __set_inode_rdev(struct inode *inode, struct page *node_page)
84+
static void __set_inode_rdev(struct inode *inode, struct folio *node_folio)
8585
{
86-
__le32 *addr = get_dnode_addr(inode, node_page);
86+
__le32 *addr = get_dnode_addr(inode, node_folio);
8787

8888
if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode)) {
8989
if (old_valid_dev(inode->i_rdev)) {
@@ -489,7 +489,7 @@ static int do_read_inode(struct inode *inode)
489489
}
490490

491491
/* get rdev by using inline_info */
492-
__get_inode_rdev(inode, &node_folio->page);
492+
__get_inode_rdev(inode, node_folio);
493493

494494
if (!f2fs_need_inode_block_update(sbi, inode->i_ino))
495495
fi->last_disk_size = inode->i_size;
@@ -745,7 +745,7 @@ void f2fs_update_inode(struct inode *inode, struct folio *node_folio)
745745
}
746746
}
747747

748-
__set_inode_rdev(inode, &node_folio->page);
748+
__set_inode_rdev(inode, node_folio);
749749

750750
/* deleted inode */
751751
if (inode->i_nlink == 0)

0 commit comments

Comments
 (0)