drm/etnaviv: fix NULL check before some freeing functions is not needed

Tian Tao · lynxeye-dev · commit 7d614ab2f205 · 2021-01-25T18:29:48.000+01:00
fixed the below warning:
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:84:2-8: WARNING: NULL check
before some freeing functions is not needed.

Signed-off-by: Tian Tao &lt;tiantao6@hisilicon.com&gt;
Acked-by: Christian König &lt;christian.koenig@amd.com&gt;
Signed-off-by: Lucas Stach &lt;l.stach@pengutronix.de&gt;
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
@@ -77,8 +77,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj)
 	/* Don't drop the pages for imported dmabuf, as they are not
 	 * ours, just free the array we allocated:
 	 */
-	if (etnaviv_obj->pages)
-		kvfree(etnaviv_obj->pages);
+	kvfree(etnaviv_obj->pages);
 
 	drm_prime_gem_destroy(&etnaviv_obj->base, etnaviv_obj->sgt);
 }

Original file line number	Diff line number	Diff line change
`@@ -77,8 +77,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj)`
`77`	`77`	`/* Don't drop the pages for imported dmabuf, as they are not`
`78`	`78`	`* ours, just free the array we allocated:`
`79`	`79`	`*/`
`80`		`- if (etnaviv_obj->pages)`
`81`		`- kvfree(etnaviv_obj->pages);`
	`80`	`+ kvfree(etnaviv_obj->pages);`
`82`	`81`
`83`	`82`	`drm_prime_gem_destroy(&etnaviv_obj->base, etnaviv_obj->sgt);`
`84`	`83`	`}`